Use Tailwind's context.getClassOrder(classes)
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
use-tailwind-sortclasslist
branch
from
4d83ef2
to
a398cd2
Compare
We have to keep the existing code for now, since the plugin will prefer the user's tailwind version. Hopefully we can remove this in future versions.
RobinMalfait
force-pushed
the
use-tailwind-sortclasslist
branch
from
78acda5
to
dd6c762
Compare
RobinMalfait
changed the title
context.sortClassList(classes)context.getClassOrder(classes)
This will also add the `group` and `peer` for older versions of Tailwind CSS
RobinMalfait
force-pushed
the
use-tailwind-sortclasslist
branch
from
dd6c762
to
d397efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use Tailwind's exposed
context.getClassOrder(classes)function instead. This will allow us to have some special cases in Tailwind itself (e.g.:groupandpeer). But it will also make sure that the actual sorting logic stays in this plugin.Tailwind will just expose the information required to be able to sort classes correctly. When classes are unknown, the sort order will be set to
null.Fixes: #53