Fix Dialog unmounting problem due to incorrect transitioncancel event in the Transition component on Android
#2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Desktop Sarai, Chrome, and on mobile iOS Safari the `transitioncancel` is never called on outside click of the Dialog. However, on mobile Android Chrome it _is_ called, and the `transitionend` is never triggered for _some_ reason. According to the MDN docs: > If the transitioncancel event is fired, the transitionend event will not fire. > > — https://developer.mozilla.org/en-US/docs/Web/API/Element/transitioncancel_event When testing this, I never got into the `transitionend` when I got into the `transitioncancel` first. But, once I removed the `transitioncancel` logic, the `transitionend` code _was_ being called. The code is now both simpler, and works again. The nice part is that we never did anything with the `cancel` event. We marked it as done using the `Reason.Cancelled` and that's about it.
RobinMalfait
force-pushed
the
fix/issue-2032
branch
from
daa4ed0
to
72b3949
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an odd issue where the
transitioncancelevent was fired on Android devices and thetransitionendevent was never fired. Therefore theTransitioncomponent was never "done", which in turn means that theDialognever unmounted because the internalOpenClosedstate didn't change yet.Removing the
transitioncancelevent handling altogether fixes this issue. This ensure that it now works on Android and still works on Safari, Chrome, iOS Safari, ...The good part is that we didn't really do anything with the
transitioncancelevent anyway, we just removed all the active listeners.Fixes: #2032