Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useOutsideClick, add improvements for ShadowDOM #1914

Merged
merged 4 commits into from Oct 10, 2022
Merged

Fix useOutsideClick, add improvements for ShadowDOM #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4df76e
Fix `useOutsideClick` not closing when clicking in ShadowDOM
theomessin Oct 10, 2022
aa7c341
use `getRootNode` in `useOutsideClick` for Vue
RobinMalfait Oct 10, 2022
2146cef
update changelog
RobinMalfait Oct 10, 2022
225f4e9
run prettier
RobinMalfait Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@headlessui-react/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fix `<Popover.Button as={Fragment} />` crash ([#1889](https://github.com/tailwindlabs/headlessui/pull/1889))
- Expose `close` function for `Menu` and `Menu.Item` components ([#1897](https://github.com/tailwindlabs/headlessui/pull/1897))
- Fix `useOutsideClick`, add improvements for ShadowDOM ([#1914](https://github.com/tailwindlabs/headlessui/pull/1914))

### Added

Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-react/src/hooks/use-outside-click.ts
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ export function useOutsideClick(
}

// Ignore if the target doesn't exist in the DOM anymore
if (!target.ownerDocument.documentElement.contains(target)) return
if (!target.getRootNode().contains(target)) return

// Ignore if the target exists in one of the containers
for (let container of _containers) {
Expand Down
1 change: 1 addition & 0 deletions packages/@headlessui-vue/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Expose `close` function for `Menu` and `MenuItem` components ([#1897](https://github.com/tailwindlabs/headlessui/pull/1897))
- Fix `useOutsideClick`, add improvements for ShadowDOM ([#1914](https://github.com/tailwindlabs/headlessui/pull/1914))

## [1.7.3] - 2022-09-30

Expand Down
2 changes: 1 addition & 1 deletion packages/@headlessui-vue/src/hooks/use-outside-click.ts
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ export function useOutsideClick(
}

// Ignore if the target doesn't exist in the DOM anymore
if (!target.ownerDocument.documentElement.contains(target)) return
if (!target.getRootNode().contains(target)) return

let _containers = (function resolve(containers): ContainerCollection {
if (typeof containers === 'function') {
Expand Down