Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tab incorrectly activating on focus event #1887

Merged
merged 2 commits into from Sep 30, 2022
Merged

Fix Tab incorrectly activating on focus event #1887

merged 2 commits into from Sep 30, 2022

Commits on Sep 30, 2022

  1. rework Tabs so that they don't change on focus 

    The "change on focus" was an incorrect implementation detail that made
it a bit easier but this causes a problem as seen in #1858.

If you want to conditionally check if you want to change the tab or note
(e.g. by using `window.confirm`) then the focus is lost while the popup
is shown. Regardless of your choice, the browser will re-focus the Tab
therefore asking you *again* what you want to do.

This fixes that by only activating the tab if needed while using arrow
keys or when you click the tab (not when it is focused).
    @RobinMalfait
    RobinMalfait committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    afc9129 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5ecd681 View commit details
    Browse the repository at this point in the history