Ensure Combobox.Label is properly linked when rendered after Combobox.Button and Combobox.Input components
#1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents Even when rendered after the Combobox.Input / Combobox.Button
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
Combbox.Label is properly linked when rendered after other componentsCombobox.Label is properly linked when rendered after Combobox.Button and Combobox.Input components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
Combobox.Labelis properly linked withCombobox.InputandCombobox.Button, even when rendered after these components.We do require an additional render, but now it happens automatically for you, before that you had to make a change yourself in order to trigger a re-render and "fixing" the missing link.
Fixes: #1836