Improve iOS scroll locking #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This isn't super ideal, but just preventing the default behavior on the entire document while `touchmove`-ing isn't ideal either because then you can't scroll inside the dialog or on the backdrop if your dialog panel is larger than the viewport. Again, this is not 100% correct, but it is better because you will be able to scroll the dialog, and not the body.
RobinMalfait
force-pushed
the
fix/ios-scroll-on-overlay
branch
from
7b1a6d5
to
5175992
Compare
|
Thank you for improving this. This fixed the following bug for me. Input elements of the type range could hardly be used by touch devices. with headlessui/vue@1.7.0: with headlessui/vue@1.7.1: I am mentioning this, because it took me a long time to find out that the reason for my particular problem was the scroll locking. Maybe somebody with a similar issue will find my comment 😉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't super ideal, but just preventing the default behavior on the
entire document while
touchmove-ing isn't ideal either because thenyou can't scroll inside the dialog or on the backdrop if your dialog
panel is larger than the viewport.
Again, this is not 100% correct, but it is better because you will be
able to scroll the dialog, and not the body.
Fixes: #1831