Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility when announcing Listbox.Option and Combobox.Option components #1812

Merged
merged 3 commits into from Sep 2, 2022
Merged

Improve accessibility when announcing Listbox.Option and Combobox.Option components #1812

merged 3 commits into from Sep 2, 2022

Commits on Sep 2, 2022

  1. ensure that aria-selected is explicitly set to false 

    The WAI-ARIA Best Practices don't recommend this and prefer
`aria-selected: true` or undefined (aka not existing when it is
"false"). However in practice, both MacOS VoiceOver and NVDA experience
strange issues if you don't do this (e.g.: everything before the
selected item is also selected)
    @RobinMalfait
    RobinMalfait committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a6637eb View commit details
    Browse the repository at this point in the history

  2. update tests to ensure we are checking for aria-selected=false

    @RobinMalfait
    RobinMalfait committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8e8814e View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    75a85f9 View commit details
    Browse the repository at this point in the history