Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displayValue syncing problem #1755

Merged
merged 11 commits into from Aug 10, 2022
Merged

Fix displayValue syncing problem #1755

merged 11 commits into from Aug 10, 2022

Conversation

thecrypticace
Copy link
Contributor

Fixes #1735

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 4:37PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 4:37PM (UTC)

@JesusTheHun
Copy link

JesusTheHun commented Sep 2, 2022

Hi,

This PR breaks the fix provided to #1675 .
The test named conditionally rendering the input should allow changing the display value has been overwritten by another test while keeping its name, and does not test said behaviour.
Using the latest revision of main, the original test does not pass.

Edit : also note that should reflect the value in the input when the value changes and when you are typing is currently pending (using xit) and currently does not pass.

@JesusTheHun
Copy link

@thecrypticace @RobinMalfait did you have a chance to take a look at my previous message ? This blocks a big release on my software, quite annoying :/ If I can be of any help, let me know.

@thecrypticace
Copy link
Contributor Author

Hey @JesusTheHun sorry we didn't see your old message. Comments on older issues tend to get lost. I've added this to our internal todo list to take a look. Thanks for bringing it up.

@JesusTheHun
Copy link

Hello @thecrypticace, do you have any ETA on this ?
Also, would you mind re-opening this issue ? It makes me feel nervous that it might be forgotten again 😅
Some love from France <3

@thecrypticace
Copy link
Contributor Author

Sorry, not at the moment. We have been crazy busy with Tailwind CSS v3.2! And have some other things coming up soon. I've reopened the issue and will take a look as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Severe] Using Combobox.Input with displayValue breaks the input behaviour
3 participants