Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Combobox re-opening keyboard issue on mobile #1732

Merged
merged 2 commits into from Aug 1, 2022
Merged

Improve Combobox re-opening keyboard issue on mobile #1732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba66d6
prevent re-focusing Combobox Input after choosing selection
RobinMalfait Aug 1, 2022
895030c
update changelog
RobinMalfait Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@headlessui-react/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improve event handler merging ([#1715](https://github.com/tailwindlabs/headlessui/pull/1715))
- Fix incorrect scrolling to the bottom when opening a `Dialog` ([#1716](https://github.com/tailwindlabs/headlessui/pull/1716))
- Make form components uncontrollable ([#1683](https://github.com/tailwindlabs/headlessui/pull/1683))
- Improve `Combobox` re-opening keyboard issue on mobile ([#1732](https://github.com/tailwindlabs/headlessui/pull/1732))

## [1.6.6] - 2022-07-07

Expand Down
1 change: 0 additions & 1 deletion packages/@headlessui-react/src/components/combobox/combobox.tsx
View file
Open in desktop
Expand Up @@ -1069,7 +1069,6 @@ let Option = forwardRefWithAs(function Option<
select()
if (data.mode === ValueMode.Single) {
actions.closeCombobox()
data.inputRef.current?.focus({ preventScroll: true })
}
})

Expand Down
1 change: 1 addition & 0 deletions packages/@headlessui-vue/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix incorrect scrolling to the bottom when opening a `Dialog` ([#1716](https://github.com/tailwindlabs/headlessui/pull/1716))
- Don't overwrite `element.focus()` on `<PopoverPanel>` ([#1719](https://github.com/tailwindlabs/headlessui/pull/1719))
- Make form components uncontrollable ([#1683](https://github.com/tailwindlabs/headlessui/pull/1683))
- Improve `Combobox` re-opening keyboard issue on mobile ([#1732](https://github.com/tailwindlabs/headlessui/pull/1732))

## [1.6.7] - 2022-07-12

Expand Down
1 change: 0 additions & 1 deletion packages/@headlessui-vue/src/components/combobox/combobox.ts
View file
Open in desktop
Expand Up @@ -915,7 +915,6 @@ export let ComboboxOption = defineComponent({
api.selectOption(id)
if (api.mode.value === ValueMode.Single) {
api.closeCombobox()
dom(api.inputRef)?.focus({ preventScroll: true })
}
}

Expand Down