hostinfo, tailcfg: add desktop environment to hostinfo #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll also note that I had to manually update the generated file due to golang/go#51629 |
maisem
reviewed
Apr 12, 2022
bradfitz
reviewed
Apr 12, 2022
twitchyliquid64
force-pushed
the
tom/desktop-hostinfo
branch
2 times, most recently
from
04b9f09
to
07dd5a4
Compare
bradfitz
approved these changes
Apr 18, 2022
twitchyliquid64
force-pushed
the
tom/desktop-hostinfo
branch
from
07dd5a4
to
9e09754
Compare
|
Changed logic to only cache the desktop/not-desktop determination after a minute - based on slack convo. |
twitchyliquid64
force-pushed
the
tom/desktop-hostinfo
branch
from
9e09754
to
e0b8705
Compare
bradfitz
reviewed
Apr 18, 2022
twitchyliquid64
force-pushed
the
tom/desktop-hostinfo
branch
from
e0b8705
to
00517c7
Compare
bradfitz
reviewed
Apr 18, 2022
From the machines tab its hard to differenciate desktop Linux installs from server Linux installs. Transmitting this information should make this determination a lot easier. Due to the reality that tailscaled is likely a system process, the standard checks based on XDG_SESSION_TYPE or DISPLAY environment variables are not possible (those variables won't be set). Instead, we look for listening unix sockets that are typical of desktop installs. Signed-off-by: Tom DNetto <tom@tailscale.com>
twitchyliquid64
force-pushed
the
tom/desktop-hostinfo
branch
from
00517c7
to
dd860bc
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the machines tab its hard to differenciate desktop Linux installs from server Linux installs. Transmitting this information should make this determination a lot easier.
Due to the reality that tailscaled is likely a system process, the standard checks based on XDG_SESSION_TYPE or DISPLAY environment variables are not possible (those variables won't be set). Instead, we look for listening unix sockets that are typical of desktop installs.