util/lru: add Clear method #12176
Merged
util/lru: add Clear method #12176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tailscale/corp#20109 Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: I751a669251a70f0134dd1540c19b274a97608a93
andrew-d
force-pushed
the
andrew/lru-clear
branch
from
db33e16
to
dfa66b0
Compare
maisem
reviewed
May 17, 2024
| @@ -68,6 +68,12 @@ func (c *Cache[K, V]) Set(key K, value V) { | |||
| } | |||
| } | |||
|
|
|||
| // Clear removes all items from the cache. | |||
| func (c *Cache[K, V]) Clear() { | |||
| c.head = nil | |||
There was a problem hiding this comment.
how about *c = Cache[K,V]{MaxEntries: c.MaxEntries}
There was a problem hiding this comment.
Not a huge fan of the "assign to struct receiver" pattern, thing; it's a bit confusing if you haven't seen it.
maisem
approved these changes
May 17, 2024
|
(test failure is unrelated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/corp#20109
Change-Id: I751a669251a70f0134dd1540c19b274a97608a93