client/web: add support for zst precomppressed assets #12170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaappasamy
approved these changes
May 17, 2024
raggi
force-pushed
the
raggi/web-zst-precompress
branch
4 times, most recently
from
c6cfb56
to
5071bbb
Compare
|
I updated some more to do the build side, and tested against chrome with a local workspace setup, updating the build in the prebuilt repo locally. I caught a window size limit error with chrome, and that is also now fixed, so these are serving successfully now with precompressed zstd. |
raggi
force-pushed
the
raggi/web-zst-precompress
branch
4 times, most recently
from
211b9ca
to
a9637fd
Compare
soniaappasamy
approved these changes
May 17, 2024
raggi
force-pushed
the
raggi/web-zst-precompress
branch
6 times, most recently
from
d1f3ef8
to
6bbddf3
Compare
This will enable us to reduce the size of these embedded assets. Updates tailscale/corp#20099 Signed-off-by: James Tucker <james@tailscale.com>
raggi
force-pushed
the
raggi/web-zst-precompress
branch
from
6bbddf3
to
f39ac7d
Compare
bradfitz
reviewed
May 19, 2024
| return f, nil | ||
| } | ||
| } | ||
| if tswebutil.AcceptsEncoding(r, "br") { |
There was a problem hiding this comment.
Maybe it's time to drop Brotli to make up for the increased cost/size of adding zstd?
Safari users can use gzip for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to reduce the size of these embedded assets.
Updates tailscale/corp#20099