Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicapi: include user and device invites, and point existing docs to the new format. #12168

Merged
merged 1 commit into from
May 17, 2024

Conversation

catzkorn
Copy link
Member

This PR does two things:

  1. Updates the new publicapi docs to include the user and device invites
  2. Edits the existing api.md file to point the TOC at the new documentation home, and removes the API docs content since it will live in the new folder!.

This change includes the device and user invites API docs in the
new publicapi documentation structure.

Updates tailscale/corp#19526

Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com>
@willnorris
Copy link
Member

willnorris commented May 17, 2024

I should have caught this on the previous PR, but consider renaming overview.md to readme.md so that it gets rendered on this page: https://github.com/tailscale/tailscale/tree/catzkorn/updateapi/publicapi ?

I worry a little bit that if a user lands on https://github.com/tailscale/tailscale/blob/catzkorn/updateapi/publicapi/device.md, it's not obvious in this structure how to find the rest of the documentation. One way would be to go back to the publicapi directory, so having the overview page render there would be very helpful.

api.md Outdated
- Get a device: [`GET /api/v2/device/{deviceid}`](#get-device)
- Delete a device: [`DELETE /api/v2/device/{deviceID}`](#delete-device)
- Expire device key: [`POST /api/v2/device/{deviceID}/expire`](#expire-device-key)
- Get a device: [`GET /api/v2/device/{deviceid}`](./publicapi/device.md#get-device)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on adding links to each of these rows that match the previous headers down below?

E.g.

<a name="device-get"></a>

That way if anyone had a link to a previous header, it would at least take them to the item in the table of contents where they should click through to the docs.

@catzkorn catzkorn merged commit c56e0c4 into main May 17, 2024
47 checks passed
@catzkorn catzkorn deleted the catzkorn/updateapi branch May 17, 2024 22:55
Mmx233 pushed a commit to MultiMx/tailscale that referenced this pull request May 20, 2024
…le#12168)

This change includes the device and user invites API docs in the
new publicapi documentation structure.

Updates tailscale/corp#19526

Signed-off-by: Charlotte Brandhorst-Satzkorn <charlotte@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants