Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: enable proguard #399

Merged
merged 1 commit into from
May 22, 2024
Merged

android: enable proguard #399

merged 1 commit into from
May 22, 2024

Conversation

kari-ts
Copy link
Contributor

@kari-ts kari-ts commented May 16, 2024

No description provided.

Signed-off-by: kari-ts <kari@tailscale.com>
@kari-ts kari-ts requested a review from raggi May 16, 2024 22:52
Copy link
Member

@raggi raggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still retain everything needed over JNI?

@kari-ts
Copy link
Contributor Author

kari-ts commented May 17, 2024

@raggi I think so, but I'm not sure. I included

-keepclasseswithmembernames class * {
    native <methods>;
} 

and then I built the app and bashed on it a bit. Other than that, is there anything I can do to check to make sure that I'm keeping everything that we need?

@kari-ts kari-ts requested a review from raggi May 22, 2024 22:13
@raggi
Copy link
Member

raggi commented May 22, 2024

@raggi I think so, but I'm not sure. I included

-keepclasseswithmembernames class * {
    native <methods>;
} 

and then I built the app and bashed on it a bit. Other than that, is there anything I can do to check to make sure that I'm keeping everything that we need?

Ah neat, I'd missed this in proguard in the past (or it's new).

@kari-ts kari-ts merged commit e826a17 into main May 22, 2024
4 of 5 checks passed
@kari-ts kari-ts deleted the kari/shrink branch May 22, 2024 23:37
kari-ts added a commit that referenced this pull request May 29, 2024
Signed-off-by: kari-ts <kari@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants