android/docker: update makefile and dockerfile for build automation #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raggi
reviewed
May 14, 2024
raggi
reviewed
May 14, 2024
raggi
reviewed
May 14, 2024
raggi
reviewed
May 14, 2024
| @@ -82,7 +85,7 @@ tailscale-debug: $(DEBUG_APK) ## Build the debug APK | |||
|
|
|||
| .PHONY: release | |||
| release: tailscale.jks $(RELEASE_AAB) ## Build the release AAB | |||
| jarsigner -sigalg SHA256withRSA -digestalg SHA-256 -keystore tailscale.jks $(RELEASE_AAB) tailscale | |||
| jarsigner -sigalg SHA256withRSA -digestalg SHA-256 -keystore tailscale.jks -storepass $(JKS_PASSWORD) $(RELEASE_AAB) tailscale | |||
There was a problem hiding this comment.
does this fail if i make a release build but I don't have a password?
There was a problem hiding this comment.
The release build always required that you enter the JKS password manually. There will be a check in the corp builder to ensure JKS_PASSWORD is set and we'll error out before we try the build (and defer the remove-image job). I'll also add a post build check to make sure things are properly signed.
barnstar
force-pushed
the
jonathan/docker_make
branch
from
c36455c
to
a0a181a
Compare
Updates tailsale/corp#19670 Added a dockerfile to run the full release build in addition to the shell environment. The build will now look for JKS_PASSWORD in the environment for completing the signing step without user interaction. Several smaller recipes added to the makefile for building the docker builder image, running and cleaning it up independently to make debugging issues quicker. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
agottardo
approved these changes
May 17, 2024
barnstar
force-pushed
the
jonathan/docker_make
branch
from
a0a181a
to
391dcb0
Compare
raggi
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailsale/corp#19670
Added a dockerfile where can run full release build in addition to dropping into a shell.
The build will now look for JKS_PASSWORD in the environment for completing the signing step without user interaction.
Several smaller recipes added to the makefile for building the docker builder image, running and cleaning it up.