android: make disconnected notification non-foreground #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
reviewed
May 13, 2024
kari-ts
changed the title
|
Put disconnected notification back in, but it is no longer a persistent notification. Also fix issue so that the correct notification is used for always-on VPN and when IPNService is restarted after being killed |
oxtoacart
reviewed
May 28, 2024
| @@ -41,6 +41,7 @@ open class IPNService : VpnService(), libtailscale.IPNService { | |||
| // This means we were started by Android due to Always On VPN. | |||
| // Get the application to make sure it's been initialized, then | |||
| // request the VPN. | |||
| showForegroundNotification() | |||
There was a problem hiding this comment.
Have you tested this? I think it might not work because I'm not sure that startForeground() has been called in this case.
There was a problem hiding this comment.
Using non-foreground notification. Also canceling notifications when App closes to clear any lingering notifications, and only showing a disconnected notification when in the Stopped state.
kari-ts
force-pushed
the
kari/note
branch
2 times, most recently
from
fc6e776
to
acd0e6f
Compare
Follow-up to #389 Only use foreground notifications when VPN was started as a foreground service. Updates #cleanup Signed-off-by: kari-ts <kari@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #389
Use foreground notifications only when the service was started as a foreground service
Updates #cleanup