Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hyper #21

Closed
wants to merge 4 commits into from
Closed

Remove hyper #21

wants to merge 4 commits into from

Conversation

pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Feb 13, 2016

Closes #15

@tailhook
Copy link
Owner

Well, most things are okay there, but I'm don't like 37cf865 too much. Some things there are deliberate, not just mistakes. I'm going to apply that in patch mode, picking things one by one.

Was all of that suggested by clippy, or you just grouped a bunch of non-significant changes together?

@pyfisch
Copy link
Contributor Author

pyfisch commented Feb 13, 2016

Almost all changes in 37cf865 where suggested by clippy. The only thing I changed myself was eq_ignore_ascii_case. Are there specific code constructs you do not like in rotor-http? If so I will avoid them in my own future code.

@tailhook
Copy link
Owner

Okay, I don't like implicit return. It's okay in one-liners, and when there is Ok(), but bare 'true' at the end of function look ugly.

Other things I've rolled back are specific to the code:

  • header checking, it's structured as nested ifs intentionally (header -- outer, value -- inner)
  • structure matching in done_headers uses _ on fields and not .. to make code more explicit

@tailhook tailhook closed this Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants