-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix main.sh
: bail on semver operators
#26
Conversation
c4086c8
to
522ca21
Compare
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
522ca21
to
0a719ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Well, we can also reduce complexity by accepting some odd versions like if [[ ! "${version}" =~ ^[0-9]+(\.[0-9]+(\.[0-9]+)?)?(-[0-9A-Za-z\.-]+)?(\+[0-9A-Za-z\.-]+)?$|^latest$ ]]; then
I'm not very familiar with python, so there is no possibility to do that in this repository. Btw, as for reducing the complexity of install-action, improving maintainability, and support for #1, #5, #25, etc., I'm thinking of managing the package information as json or another and fetching the latest version's package information in CI to automatically update (like my other repos I mentioned in #5 (comment)). |
I'm fine with this PR.
That will definitely makes updating a lot easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com