If optional dependency raises the requirements of other dependencies, the current approach may miss the problem #6
Labels
Comments
dburgener
added a commit
to dburgener/quick-xml
that referenced
this issue
Feb 23, 2023
The 2.0 family of memchr doesn't build in this crate. This is hard to see using cargo minimal-versions because tokio depends on memchr 2.2, which raises the dependency using minimal-versions even when tokio is disabled. This is a known issue with cargo-minimal-versions: taiki-e/cargo-minimal-versions#6 So everything looks fine from the perspective of this crate, but consumers who use quick_xml without the optional features that enable the tokio dependency have a minimal version down to 2.0, which breaks. To reproduce in this crate, I commented out the tokio and async_tokio lines in Cargo.toml and ran cargo minimal-versions, which produces the errors, and emulates the conditions an external user might experience.
Mingun
pushed a commit
to tafia/quick-xml
that referenced
this issue
Feb 24, 2023
The 2.0 family of memchr doesn't build in this crate. This is hard to see using cargo minimal-versions because tokio depends on memchr 2.2, which raises the dependency using minimal-versions even when tokio is disabled. This is a known issue with cargo-minimal-versions: taiki-e/cargo-minimal-versions#6 So everything looks fine from the perspective of this crate, but consumers who use quick_xml without the optional features that enable the tokio dependency have a minimal version down to 2.0, which breaks. To reproduce in this crate, I commented out the tokio and async_tokio lines in Cargo.toml and ran cargo minimal-versions, which produces the errors, and emulates the conditions an external user might experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See tokio-rs/tracing#2015 (comment) for details.
The text was updated successfully, but these errors were encountered: