Skip to content

Commit

Permalink
Indicate minimum version 2.1 for memchr dependency
Browse files Browse the repository at this point in the history
The 2.0 family of memchr doesn't build in this crate.  This is hard to
see using cargo minimal-versions because tokio depends on memchr 2.2,
which raises the dependency using minimal-versions even when tokio is
disabled.  This is a known issue with cargo-minimal-versions:

taiki-e/cargo-minimal-versions#6

So everything looks fine from the perspective of this crate, but
consumers who use quick_xml without the optional features that enable
the tokio dependency have a minimal version down to 2.0, which breaks.

To reproduce in this crate, I commented out the tokio and async_tokio
lines in Cargo.toml and ran cargo minimal-versions, which produces the
errors, and emulates the conditions an external user might experience.
  • Loading branch information
dburgener committed Feb 23, 2023
1 parent f0b3420 commit ced978f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ document-features = { version = "0.2", optional = true }
encoding_rs = { version = "0.8", optional = true }
serde = { version = "1.0.100", optional = true }
tokio = { version = "1.0", optional = true, default-features = false, features = ["io-util"] }
memchr = "2.0"
memchr = "^2.1"

[dev-dependencies]
criterion = "0.4"
Expand Down

0 comments on commit ced978f

Please sign in to comment.