Pin watchdog at a version before 0.10.4. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like watchdog made a change to the exact events emitted on macOS, in a way that cause our mapping to inotify-like flags + our tests to start failing. I'm guessing this wasn't noticed, since we weren't running macOS tests on PRs. This is probably due to gorakhargosh/watchdog#680, but I suspect the issue is that we are getting more events than we expect, and the first one doesn't match the one we test for. Since we aren't currently using this code, I'm going to pin to a version that passes the tests, until we get around to using this code.
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 84.09% 88.60% +4.51%
==========================================
Files 31 31
Lines 2326 2326
Branches 276 276
==========================================
+ Hits 1956 2061 +105
+ Misses 295 182 -113
- Partials 75 83 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like watchdog made a change to the exact events emitted on macOS,
in a way that cause our mapping to inotify-like flags + our tests to start failing.
I'm guessing this wasn't noticed, since we weren't running macOS tests on PRs.
This is probably due to gorakhargosh/watchdog#680, but
I suspect the issue is that we are getting more events than we expect, and the
first one doesn't match the one we test for.
Since we aren't currently using this code, I'm going to pin to a version that
passes the tests, until we get around to using this code.