Allow override of default escape/unescape behavior in more situations #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a breaking change since `escape`, `partial_escape`, and `minimal_escape` were trivially re-implemented in terms of `escape_with`. Introduces slight overhead for double `Option` checking that could be sidestepped with some very light unsafe.
This involves swapping the order in which the main loop of that function checks for `named_entitites` and `entity_resolver` closures, namely we check the user-provided `entity_resolver` first. This shouldn't be a breaking change unless some existing client code already had overridden `named_entity` replacements, but those replacements would have been noops under the previous implementation so the fix should be trivial.
phdavis1027
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 61.48% 61.74% +0.26%
==========================================
Files 38 38
Lines 16213 16306 +93
==========================================
+ Hits 9968 10068 +100
+ Misses 6245 6238 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #734, adds tests to verify that no functionality was lost.