Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks in compare project #644

Merged
merged 6 commits into from Sep 9, 2023
Merged

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Sep 9, 2023

After #490 attributes should be names starting from @. The RSS document used in benchmarks have attributes that mapped to a struct, that was not updated for that, which is now fixed.

Also updated all dependencies of compare and fuzz projects and switch them to Rust 2021.

@codecov-commenter
Copy link

Codecov Report

Merging #644 (19b2568) into master (9a9b9fc) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   64.43%   64.43%           
=======================================
  Files          36       36           
  Lines       17288    17288           
=======================================
  Hits        11140    11140           
  Misses       6148     6148           
Flag Coverage Δ
unittests 64.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Mingun
Copy link
Collaborator Author

Mingun commented Sep 9, 2023

Interesting, that almost in all benchmarks maybe_xml is the first and quick_xml is the second. This is very impressful, because maybe_xml implements parsing using only the standard library and does not have any dependencies at all.

@dralley dralley merged commit cced485 into tafia:master Sep 9, 2023
6 checks passed
@Mingun Mingun deleted the fix-benches branch September 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants