Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Clone for error enums #521

Merged
merged 3 commits into from Dec 8, 2022
Merged

Implement Clone for error enums #521

merged 3 commits into from Dec 8, 2022

Commits on Dec 8, 2022

  1. Bump MSRV to 1.52 

    We'll be making use `impl<E: Error> Error for Arc<E>` that was introduced
in 1.52.
    @zeenix
    zeenix committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0fb0344 View commit details
    Browse the repository at this point in the history

  2. Drop some unneeded Result::map_err calls 

    The `?` handles the tranformation for us.
    @zeenix
    zeenix committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2e5d897 View commit details
    Browse the repository at this point in the history

  3. Implement Clone for error enums 

    This would allow using crates to embed errors from this crate into their
error types that implement Clone.

Unfortunately `std::io::Error` does not implement `Clone` [1] so we've
to wrap it in an `Arc`.
    @zeenix
    zeenix committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    661d117 View commit details
    Browse the repository at this point in the history