Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #517: Fix swapped codes for \r and \n characters when escape them #519

Merged
merged 1 commit into from Dec 2, 2022

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Dec 2, 2022

Some tests was changed for consistency.

@Mingun Mingun added the bug label Dec 2, 2022
@Mingun Mingun requested a review from dralley December 2, 2022 16:02
@Mingun Mingun linked an issue Dec 2, 2022 that may be closed by this pull request
Changelog.md Outdated
@@ -28,6 +28,7 @@
```
- [#514]: Fix wrong reporting `Error::EndEventMismatch` after disabling and enabling
`.check_end_names`
- [#517]: Fix swapped codes for `\r` and `\n` characters when escape them
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/escape/escaping

…caping them

Co-authored-by: Daniel Alley <dalley@redhat.com>
@Mingun Mingun merged commit fb079b6 into tafia:master Dec 2, 2022
@Mingun Mingun deleted the fix-eol-escape branch December 2, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping for \r and \n have wrong value
2 participants