New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional tests for borrowed input #509
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any concept of opportunistic zero-copy with
Cow<&str>
? As someone not terribly familiar with serde.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand you correctly,
Cow<str>
will borrow whenever possible i. e. when deserializer can provide data of underlying source by callingVisitor::visit_borrowed_str
. The opposite case when the deserializer allocatesString
by itself and callsVisitor::visit_string
. The intermediate case when deserializer provides borrow to the data, that it owns, viaVisitor::visit_str
.In our case we can either provide access to the XML source by calling
Visitor::visit_borrowed_str
, or allocate a newString
(because we in any case need to allocate to do unescaping and/or decoding) and give it to theVisitor
. If XML in UTF-8 and does not contain escaped data or mixed text/CDATA or CDATA/CDATA content (after solving #474), the data will be borrowed