Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of top-level sequences of enums #501

Merged
merged 3 commits into from Oct 30, 2022

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Oct 29, 2022

Fixes #500. The behavior of top-level sequence actually very simple -- try to deserialize until Eof is received, which is the only stop marker.

After the fix in the first commit it became obvious, that some refactoring could be done to put highly coupled code together, which is done in the next 2 commits.

@Mingun Mingun added bug serde Issues related to mapping from Rust types to XML arrays Issues related to mapping XML content onto arrays using serde labels Oct 29, 2022
@Mingun Mingun requested a review from dralley October 29, 2022 10:17
@codecov-commenter
Copy link

Codecov Report

Merging #501 (caab890) into master (0c6eeb0) will decrease coverage by 0.09%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   61.70%   61.61%   -0.10%     
==========================================
  Files          33       32       -1     
  Lines       15343    15307      -36     
==========================================
- Hits         9468     9432      -36     
  Misses       5875     5875              
Flag Coverage Δ
unittests 61.61% <94.11%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/de/mod.rs 67.16% <83.33%> (-0.07%) ⬇️
src/de/map.rs 71.36% <96.42%> (+3.29%) ⬆️
src/escapei.rs 12.35% <0.00%> (-0.18%) ⬇️
src/reader/mod.rs 92.04% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/de/seq.rs Show resolved Hide resolved
src/de/map.rs Show resolved Hide resolved
src/de/seq.rs Show resolved Hide resolved
@dralley dralley merged commit a54f6c2 into tafia:master Oct 30, 2022
@Mingun Mingun deleted the seq-of-enum branch October 30, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays Issues related to mapping XML content onto arrays using serde bug serde Issues related to mapping from Rust types to XML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequences of enums at root level are not parsed correctly
3 participants