Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy issues #494

Merged
merged 1 commit into from Feb 17, 2023
Merged

Fix clippy issues #494

merged 1 commit into from Feb 17, 2023

Conversation

dacut
Copy link
Contributor

@dacut dacut commented Oct 8, 2022

This PR fixes a few issues identified via cargo clippy --all-features. I interspersed a few #[allow(clippy::...)] bits where it seemed like readability was more important than the changes Clippy was suggesting or where performance might be affected (notably cases where &Cow<> is taken as a parameter instead of Cow<>, seemingly intentionally).

Might hold off on this one until the serialization PR (#490) lands; I can fix the conflicts that will result afterward.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #494 (864b733) into master (221b57d) will increase coverage by 0.03%.
The diff coverage is 42.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   61.25%   61.28%   +0.03%     
==========================================
  Files          32       32              
  Lines       15654    15649       -5     
==========================================
+ Hits         9589     9591       +2     
+ Misses       6065     6058       -7     
Flag Coverage Δ
unittests 61.28% <42.85%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/custom_entities.rs 0.00% <0.00%> (ø)
examples/nested_readers.rs 0.00% <0.00%> (ø)
src/de/mod.rs 56.44% <ø> (+0.23%) ⬆️
src/de/simple_type.rs 93.65% <ø> (ø)
src/events/mod.rs 71.64% <0.00%> (ø)
src/reader/ns_reader.rs 63.71% <ø> (ø)
src/reader/slice_reader.rs 100.00% <ø> (ø)
src/utils.rs 73.22% <0.00%> (+0.57%) ⬆️
src/events/attributes.rs 93.56% <50.00%> (ø)
src/escapei.rs 13.24% <100.00%> (-0.06%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dralley
Copy link
Collaborator

dralley commented Feb 16, 2023

@dacut Could you rebase?

@dacut
Copy link
Contributor Author

dacut commented Feb 16, 2023

Ah, missed that the other issue was resolved. Will rebase and resolve.

@dacut
Copy link
Contributor Author

dacut commented Feb 16, 2023

Ok, rebased. cargo clippy is still (amazingly) showing clean, despite all the changes made to clippy in the meantime. (A lot of my projects with clippy checks broke recently.)

@dralley dralley merged commit bd81d33 into tafia:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants