Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use UTF-8 for a Reader and a Deserializer created from a string #403

Merged
merged 2 commits into from Jun 24, 2022

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Jun 24, 2022

Fixes #324

@Mingun Mingun requested a review from dralley June 24, 2022 16:28
@Mingun Mingun added the encoding Issues related to support of various encodings of the XML documents label Jun 24, 2022
src/reader.rs Outdated Show resolved Hide resolved
src/reader.rs Outdated Show resolved Hide resolved
Co-authored-by: Daniel Alley <dalley@redhat.com>
@Mingun Mingun merged commit f6d5e99 into tafia:master Jun 24, 2022
@Mingun Mingun deleted the lock-encoding branch June 24, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding Issues related to support of various encodings of the XML documents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_str should ignore encoding in XML declaration
2 participants