Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for #280 #303

Closed
wants to merge 1 commit into from
Closed

Add a test for #280 #303

wants to merge 1 commit into from

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented Aug 11, 2021

Currently fails: #280

@Mingun Mingun added the serde Issues related to mapping from Rust types to XML label May 21, 2022
@Mingun
Copy link
Collaborator

Mingun commented May 21, 2022

As I already said in Mingun/fast-xml#2, it is better to test actual result and not roundtrips, because deserializer is able to deserialize different shaped into the same structure, and for serializer we usually want some exact format (because usually XML has a scheme and that scheme is not under our control).

Because I'll plan to look serializer issues more closely when I'll finish with deserializer, I suggest close this for now.

@dralley
Copy link
Collaborator Author

dralley commented May 21, 2022

I'll close it for now, once I get some free time on a weekend I will try to address your feedback, presuming you don't get to it first :)

@dralley dralley closed this May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serde Issues related to mapping from Rust types to XML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants