Fix serialization of structs #205
Conversation
Attributes were being created as child elements. This works correctly if the simple types that should be attributes are kept at the beginning of the struct and the more complex types that should be children are after all of the simple types. To solve this correctly, there should probably be two Vecs, one for the attributes and one for the children.
instead of #[cfg(feature = "failed_test")] to disable failing tests.
|
Thanks for the PR!! |
|
Note, to solve this correctly, there should probably be two Vecs, one for the attributes and one for the children. serialize_field() would need to collect the Vecs, then end() would serialize the result. The problem with that is Serialize cannot be used to create a trait object. If someone wanted to integrate the erased-serde crate, they could probably make that work. |
|
I wish I had the knowledge to merge this. It's too old. |
|
Since merging #490 the attributes should be marked explicitly in structs, by prepending |
Attributes were being created as child elements.
This works correctly if the simple types that should be attributes are
kept at the beginning of the struct and the more complex types that
should be children are after all of the simple types.
To solve this correctly, there should probably be two Vecs, one for the
attributes and one for the children.