Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#162105][WIP] Tech Task: Handle mime type errors #3905

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

giladshanan
Copy link
Contributor

@giladshanan giladshanan commented Dec 19, 2023

Release Notes

This type of error pops up from time to time, the result of a security scan. This refactors error handling to a more modern pattern, while at the same time handling mime type errors properly so they don't create noise in Rollbar.

See:

To Do

  • Remove unused boiler plate from generator
  • Add and/or update specs
  • Local testing of mime type handling

@giladshanan giladshanan changed the title [#162105] Tech Task: Handle mime type errors [#162105][WIP] Tech Task: Handle mime type errors Dec 19, 2023
@LeticiaErrandonea
Copy link
Contributor

Couldn't fix the specs, but it looks like a config issue (works for local but consistently fails for test env).

I tried recommendations here and didn't work. Issue is that the ErrorsController doesn't get hit when the exception is raised.

@jossim jossim force-pushed the 162105-handle-mime-type-errors branch from 2535773 to 85d4116 Compare February 6, 2024 21:10
@jossim jossim self-requested a review February 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants