otelhttp: add service name #343
Conversation
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
| } | ||
|
|
||
| func (lh *labeledHandler) ServeHTTP(rw http.ResponseWriter, r *http.Request) { | ||
| labeler, _ := otelhttp.LabelerFromContext(r.Context()) |
There was a problem hiding this comment.
The otelhttp.NewHandler in L13 creates a http.Handler that internally creates an internal &Labeler{}.
That means that in wrapped internal http.Handlers, middlewares can do otelhttp.LabelerFromContext(...) can get that "base labeler". That allows each handler to add custom extra attributes to be included in captured metrics.
This is exactly what we need. What we do is always include the service_name form the new metrics.BaseAttrs.
The same mechanics might be useful if we want to include custom labels in different handlers. For example, we could try including the chain_id, so we can have all the otelhttp metrics we have today, but also separated by chain_id, which we don't have.
We can think if that's useful in the future, it would be an easy addition. I'd have to just do both L22-L23-ish in the "chain id" detection middleware.
Summary
This PR solves, hopefully, the last breaking change of OTEL default attributes behavioral change.
In the testnet dashboard, some tiles don't show information:
In the staging dashboard I deployed this PR and it shows data correctly.
Context
#323
Implementation overview
Luckily, after digging into the
otelhttp, I saw that you can inject custom labels if you do an extra middleware wrapping.It'll become clear while seeing the code.
Implementation details and review orientation
NA