⬆️ Allow more recent version of packaging #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @r-richmond to sign the Salesforce.com Contributor License Agreement. |
|
CLA signed previously as noted here |
|
hm, looks like that brings in some changes from black as well. Can you run black to get the code back into a valid state? It looks like the vast majority of changes are this one: Also, could you bump the named version to 22.0, for clarity? |
|
Addressed both black run & bumping minimum version as requested (also added comment for more clarity) |
jacalata
approved these changes
Feb 21, 2023
|
@jacalata do you have a rough estimate for when the next version will go out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make change
The current specification conflicts with new versions of black
https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/pyproject.toml#L68
What do the new versions of packaging do
https://github.com/pypa/packaging/releases/tag/22.0
of note