Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use internal Next.js types #414

Closed
wants to merge 2 commits into from

Conversation

balazsorban44
Copy link
Contributor

Closes #412

As explained in vercel/next.js#40371 (comment)

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-08-15).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

πŸ’―

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

⚠️ No Changeset found

Latest commit: 0eb693e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 9, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
create-t3-app βœ… Ready (Inspect) Visit Preview Sep 9, 2022 at 10:45AM (UTC)

@juliusmarminge
Copy link
Member

You think this will ship in 12.3.1? vercel/next.js#40391

I personally prefer that so much more

@c-ehrlich
Copy link
Member

I would also prefer waiting it out for Next to solve this, or at least waiting a few days to see what happens to the PR.

@balazsorban44
Copy link
Contributor Author

Yep, closing this PR for now. πŸ‘ Keep an eye on vercel/next.js#40391 and feel free to PR here when that is merged.

@balazsorban44 balazsorban44 deleted the patch-1 branch September 9, 2022 11:17
@juliusmarminge
Copy link
Member

Thank you Balazs πŸ™

ijjk pushed a commit to vercel/next.js that referenced this pull request Sep 9, 2022
An alternative solution to #40371

Ref: #38867, t3-oss/create-t3-app#412,
t3-oss/create-t3-app#414

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: session type issue on NextJs 12.3.0
3 participants