New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not use internal Next.js types #414
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
You think this will ship in 12.3.1? vercel/next.js#40391 I personally prefer that so much more |
I would also prefer waiting it out for Next to solve this, or at least waiting a few days to see what happens to the PR. |
Yep, closing this PR for now. π Keep an eye on vercel/next.js#40391 and feel free to PR here when that is merged. |
Thank you Balazs π |
An alternative solution to #40371 Ref: #38867, t3-oss/create-t3-app#412, t3-oss/create-t3-app#414 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
Closes #412
As explained in vercel/next.js#40371 (comment)
β Checklist
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
π―