build: support go1.22 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes panic on go1.22, see kubernetes-sigs/controller-tools#880 and golang/go#65637 Since `go get sigs.k8s.io/controller-tools` updates transitive Kubernetes dependencies this change removes it from dependencies in favor of fixed version in the Makefile. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
| description: 'APIVersion defines the versioned schema of this representation | ||
| of an object. Servers should convert recognized schemas to the latest | ||
| internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources' | ||
| description: |- |
There was a problem hiding this comment.
The change is due to kubernetes-sigs/controller-tools#870
|
Tagged with v0.25.1 |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Mar 11, 2024
See changes szuecs/routegroup-client#31 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando/skipper
that referenced
this pull request
Mar 11, 2024
See changes * szuecs/routegroup-client#31 * szuecs/routegroup-client#32 It restores a link to the origin removed by #2814 to make it clear that CRD is the copy. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
added a commit
to zalando/skipper
that referenced
this pull request
Mar 11, 2024
See changes * szuecs/routegroup-client#31 * szuecs/routegroup-client#32 It restores a link to the origin removed by #2814 to make it clear that CRD is the copy. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes panic on go1.22, see kubernetes-sigs/controller-tools#880 and golang/go#65637
Since
go get sigs.k8s.io/controller-toolsupdates transitive Kubernetes dependencies this change removes it from dependencies in favor of fixed version in the Makefile.