Component position & parentage need to be sent together for rebaser. Send WsEvents to populate components & edges appropriately. #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
jobelenus
force-pushed
the
jobelenus/BUG-183-batch-pos-and-parent-with-ws-support
branch
2 times, most recently
from
9d76783
to
f093581
Compare
…Send WsEvents to populate components & edges appropriately.
jobelenus
force-pushed
the
jobelenus/BUG-183-batch-pos-and-parent-with-ws-support
branch
from
f093581
to
f351f4f
Compare
|
bors merge |
|
Build succeeded: |
si-bors-ng
bot
deleted the
jobelenus/BUG-183-batch-pos-and-parent-with-ws-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK—the front end now has all the info required to display sockets correctly through attach & detach. And the conflicts that happen when position and parentage are sent in separate rebases is avoided. This is the way.