feat(dal,sdf): Close and Put On hold actions v2 endpoints #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vbustamante
commented
May 10, 2024
•
vbustamante
commented
- Close actions by deleting them from the graph
- put actions on hold by updating the status
- send all actions to frontend instead of just enqueued ones
- fix some issues in the actions_v2 tests
github-actions
bot
added
A-sdf
vbustamante
commented
May 10, 2024
lib/dal/src/schema/variant.rs
Outdated
| workspace_snapshot.get_node_weight(prototype_idx).await? | ||
| else { | ||
| continue; | ||
| }; |
There was a problem hiding this comment.
This was breaking component creation when they had both new and old creation actions
| | ActionState::Failed | ||
| | ActionState::OnHold => return Err(ActionError::InvalidOnHoldTransition(request.id)), | ||
| ActionState::Queued => {} | ||
| } |
There was a problem hiding this comment.
Likewise for these ones - are these conditions correct?
There was a problem hiding this comment.
I think putting a Failed action on hold makes sense. It would effectively be re-queueing it immediately into the On Hold state.
vbustamante
force-pushed
the
victor/eng-2546-create-sdf-enpoint-that-onholds-actions-with-a-task-id-and-a
branch
from
9a3e7e7
to
7493a90
Compare
Signed-off-by: Victor Bustamante <victor@systeminit.com>
paulocsanz
force-pushed
the
victor/eng-2546-create-sdf-enpoint-that-onholds-actions-with-a-task-id-and-a
branch
from
99db381
to
41659d9
Compare
paulocsanz
force-pushed
the
victor/eng-2546-create-sdf-enpoint-that-onholds-actions-with-a-task-id-and-a
branch
from
41659d9
to
8f698e5
Compare
paulocsanz
force-pushed
the
victor/eng-2546-create-sdf-enpoint-that-onholds-actions-with-a-task-id-and-a
branch
2 times, most recently
from
982e67e
to
e62f7fe
Compare
|
bors try |
tryBuild failed: |
paulocsanz
force-pushed
the
victor/eng-2546-create-sdf-enpoint-that-onholds-actions-with-a-task-id-and-a
branch
from
e62f7fe
to
4f8127d
Compare
…ng Actions in rebaser
|
bors try |
tryBuild failed: |
|
bors merge |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
si-bors-ng
bot
deleted the
victor/eng-2546-create-sdf-enpoint-that-onholds-actions-with-a-task-id-and-a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.