Upgrade to Jest 29 #2321
Upgrade to Jest 29 #2321
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b5067e:
|
|
@hasparus any quick tips on why https://github.com/system-ui/theme-ui/actions/runs/3063545168/jobs/4945735744#step:7:34 is failing? This was happening in dev; everything worked if I |
| useESM: true, | ||
| diagnostics: { | ||
| exclude: ['**'], | ||
| transform: { |
There was a problem hiding this comment.
This makes so much more sense now.
|
I’d like to merge this for now, since it’s been over a month waiting on the Emotion package release. We can easily remove our version override in the future when it’s released, but I don’t want to deal with more merge conflicts down the road. @hasparus can you take a quick look at the React import error? |
|
Ooh makes a ton of sense, thanks! |
|
🚀 PR was released in |
|
🚀 PR was released in |
|
🚀 PR was released in |
|
🚀 PR was released in |
Though development is done on upgrading, we need to wait for the new version of @emotion/jest, since it adds compatibility with Jest 29's types, & I'd rather not merge the addition of
strict-peer-dependencies=falseto.npmrcneeded to make this work right now.In the meantime, I've closed all the Dependabot PRs since this upgrade requires code changes.