Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-theme-ui,docs): Dependency Updates #2138

Merged
merged 5 commits into from Feb 21, 2022
Merged

fix(gatsby-plugin-theme-ui,docs): Dependency Updates #2138

merged 5 commits into from Feb 21, 2022

Conversation

LekoArts
Copy link
Collaborator

@LekoArts LekoArts commented Feb 21, 2022 •
edited by hasparus

Hi!

This PR does a couple of things:

  • Update the two Gatsby examples to use Gatsby v4 + add necessary peerDeps
  • Update gatsby-plugin-theme-ui to add necessary peerDeps
  • Update README of gatsby-plugin-theme-ui and docs to include installation of peerDeps

Version

Published prerelease version: v0.14.0-develop.15

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ Brage (@braaar)

❤️ peterlits zo (@PeterlitsZo)

❤️ Ryan Turner (@rtturner)

❤️ Cannon Lock (@CannonLock)

🚀 Enhancement

  • feat(examples/next): Add new deps, fully use TSX, rebuild #2068 (@lachlanjc)
  • @theme-ui/tailwind
    • feat(tailwind): Upgrade Tailwind theme conversion for v3.0 #2082 (@lachlanjc)
  • @theme-ui/custom-properties
    • feat(custom-properties): Warn in development on invalid theme keys #2080 (@lachlanjc)
  • @theme-ui/color-modes
    • feat(color-modes): Warn when theme color keys have leading/trailing whitespace #2099 (@lachlanjc)
  • theme-ui

🐛 Bug Fix

👨‍💻 Minor changes

  • Update jsx-pragma.mdx (@hasparus)
  • docs(examples/next): fix case insensitive import (@hasparus)

🏠 Internal

Authors: 9

@vercel
Copy link

vercel bot commented Feb 21, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/2ju175mjkFrVQVJu4198JVtdKror
✅ Preview: https://theme-ui-git-fork-lekoarts-gatsby-updates-systemui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 21, 2022 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 78f969d:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

LekoArts
LekoArts commented Feb 21, 2022
View reviewed changes
examples/gatsby-plugin/package.json
"theme-ui": "latest"
},
"devDependencies": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those seemed unused

examples/gatsby/src/layout.tsx

export const Layout: FC = ({ children }) => {
const index = useBreakpointIndex({ defaultIndex: 2 })
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not used anywhere

packages/docs/src/pages/getting-started/gatsby.mdx
@@ -7,7 +7,7 @@ title: Getting Started with Gatsby
To use Theme UI with [Gatsby][], install and use [`gatsby-plugin-theme-ui`](/packages/gatsby-plugin).

```sh
npm i theme-ui gatsby-plugin-theme-ui
npm i theme-ui gatsby-plugin-theme-ui @emotion/react @emotion/styled @mdx-js/react@v1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatsby-plugin-mdx doesn't support ESM-only MDX v2 yet, so people need to install v1

lachlanjc
lachlanjc approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

examples/gatsby-plugin/src/gatsby-plugin-theme-ui/index.js Outdated Show resolved Hide resolved
examples/gatsby/src/theme.ts Outdated Show resolved Hide resolved
@LekoArts @lachlanjc
Apply suggestions from code review
78f969d 
Co-authored-by: Lachlan Campbell <lachlanjc@hey.com>
@lachlanjc lachlanjc merged commit 03c9908 into system-ui:develop Feb 21, 2022
@hasparus hasparus added the prerelease This change is available in a prerelease. label Feb 21, 2022
@LekoArts LekoArts deleted the gatsby-updates branch February 21, 2022 21:43
This was referenced Feb 27, 2022
Merged
Merged
Merged
This was referenced Mar 16, 2022
Merged
Merged
Merged
@hasparus
Copy link
Member

🚀 PR was released in v0.14.0 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlanjc lachlanjc lachlanjc approved these changes

@hasparus hasparus Awaiting requested review from hasparus hasparus is a code owner

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LekoArts @hasparus @lachlanjc