Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base-path parameter to Coveralls #219

Merged
merged 7 commits into from Mar 22, 2023
Merged

Conversation

mitchellolsthoorn
Copy link
Member

Coveralls is having trouble parsing the LCOV files generated during the test and coverage scripts. According to this issue, the base-path is necessary next to the path to LCOV to make sense of the data in the LCOV file. This was unclear from the documentation

This should fix a problem with the parsing of LCOV files
@mitchellolsthoorn mitchellolsthoorn requested a review from a team as a code owner February 16, 2023 19:11
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4197373157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 4195489852: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 4488900916

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+53.9%) to 53.931%

Totals Coverage Status
Change from base Build 4313025505: 53.9%
Covered Lines: 832
Relevant Lines: 1453

💛 - Coveralls

@mitchellolsthoorn mitchellolsthoorn marked this pull request as draft February 16, 2023 19:14
@mitchellolsthoorn
Copy link
Member Author

This apparently doesn't fix the problem

@dstallenberg dstallenberg marked this pull request as ready for review March 22, 2023 10:32
Copy link
Contributor

@dstallenberg dstallenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally coverage.

@dstallenberg dstallenberg merged commit 91bd830 into main Mar 22, 2023
13 checks passed
@dstallenberg dstallenberg deleted the mitchellolsthoorn-patch-1 branch March 22, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants