Add initial implementation

[remcohaszing]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

This is the initial implementation of unist-lsp.

[wooorm]

Probably good to tests missing props? null/undefined/invalid props?

[remcohaszing]

IMO it’s fine to rely on type information for this.

[wooorm]

I won’t veto this but generally I believe that it is important to care for users who don’t use TypeScript.
I also believe that, for an open source library, it is important to write “defensively”. As in, assume people pass weird things in, and to an extent, handle that.
People do weird things in plugins. It’s good to not crash on weird things.

[remcohaszing]

I think it depends a bit. I.e. when writing a remark plugin I tend to care about this more then when writing such low-level functions with a specific use cases like these.

[wooorm]

@remcohaszing done?

[remcohaszing]

Yep, IMO this is good to go. 👍

[wooorm]

PS I do the following in settings on new repos:

• turn wiki’s off
• turn merge/rebase off
• change squash to “default to pull request title” (I think this is new, will have to see if this works well)
• turn on suggest updating branches, auto-merge, and auto-delete branches

[github-actions]

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

[wooorm]

Meh, github-tools/npm-tools pause after like 90 days or so. Reactivated them.

[wooorm]

Ready for a release too I presume?

[remcohaszing]

Meh, github-tools/npm-tools pause after like 90 days or so. Reactivated them.

Annoying!

Ready for a release too I presume?

Yep! Let’s make it version 1.0.0.

[wooorm]

Are you sure it’s wise not to add a main to package.json. Despite what Node says in their docs, not everyone is using Node.
Not blocking to me, we can see if this works fine. But I’d err on the side of having it.

[wooorm]

Also, is rimraf no longer needed for tsc?

[wooorm]

Bundlephobia is reporting a dep is missing: https://bundlephobia.com/package/unist-lsp@1.0.0.
Not sure which one, and why?

[remcohaszing]

Also, is rimraf no longer needed for tsc?

I’m not running into any issues anyway.

Bundlephobia is reporting a dep is missing: https://bundlephobia.com/package/unist-lsp@1.0.0. Not sure which one, and why?

Oops! #2