u64 chain_id #15
Merged
u64 chain_id #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport private chains
|
LGTM, there is a warning in nightly rust to change into_iter() with iter() Also we should bump the version to 3.0.0 |
added 2 commits
November 22, 2019 12:14
|
Thanks for looking the PR over! Other than fixing the iter() thing I modified the type of chain_id to be generic, so we could avoid breaking current uses. Since this now isn't a breaking change, I figured we could bump the version to 2.1.0 instead of 3.0.0. |
|
Thank you for making this PR! I will sort out the version stuff. Happy to keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified chain_id to be u64 instead of u8
Also replaced the deprecated
complete_unbounded_listwithfinalize_unbounded_list#7