Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): disabled rule for subject-case #3317

Merged
merged 1 commit into from Jan 29, 2024

Conversation

ice0
Copy link
Collaborator

@ice0 ice0 commented Jan 29, 2024

This will allow to start subjects from uppercase words. Currently it fails on something like:

fix: Gitlab CI pipeline fixed
build: CMake sets wrong Synfig Studio/ETL versions

P.S. If I understand correctly, this change does not violate the standard.
Discussion here: conventional-changelog/commitlint#2141

P.P.S. Puppeteer did the same: https://github.com/puppeteer/puppeteer/pull/8091/files

This will allow to start subjects from uppercase words. Currently it fails on something like:
```
fix: Gitlab CI pipeline fixed
build: CMake sets wrong Synfig Studio/ETL versions
```

P.S. If I understand correctly, this change does not violate the standard.
Discussion here: conventional-changelog/commitlint#2141

P.P.S. Puppeteer did the same:
https://github.com/puppeteer/puppeteer/pull/8091/files
@ice0 ice0 merged commit 2e06938 into synfig:master Jan 29, 2024
8 checks passed
@ice0 ice0 deleted the refactor-commit-lint branch January 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants