lib/fs: Unit test to remove read only Windows files (#3744) #8651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thought skip would stop the test process here
|
The syscall functions are specific to Windows so when It tries to test for other OS, it fails even if in the first line we check if It's windows and return if not |
Sorry, not used to this kind of conf
|
Now it's just working as intended |
|
Indeed, this fails as it should since it's not fixed in this branch. I've incorporated it into my fix branch (you'll get co-author creds there) and tweaked it a little so will close this one. Thanks! |
Perfect, you're welcome ! 👍 |
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for the issue #3744