Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes #8572) #8573

Merged
merged 2 commits into from Dec 21, 2022
Merged

lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes #8572) #8573

merged 2 commits into from Dec 21, 2022

Conversation

Ratio2
Copy link
Contributor

@Ratio2 Ratio2 commented Oct 2, 2022 •
edited

No description provided.

@Ratio2 Ratio2 changed the title gui: Fix rescan interval on auto accepted encrypted folder (fixes #8… gui: Fix rescan interval on auto accepted encrypted folder (fixes #8572) Oct 2, 2022
@Ratio2 Ratio2 changed the title gui: Fix rescan interval on auto accepted encrypted folder (fixes #8572) lib/model: Fix rescan interval on auto accepted encrypted folder (fixes #8572) Oct 2, 2022
@acolomb acolomb linked an issue Oct 3, 2022 that may be closed by this pull request
Incorrect rescan interval on auto accepted encrypted folder #8572
Closed
calmh
calmh reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@calmh calmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to let it be zero if it's zero?

@Ratio2
Copy link
Contributor Author

Ratio2 commented Nov 3, 2022

I didn't understand your question, but please see a more detailed description of the change:
#8572 (comment)

@imsodin
Copy link
Member

imsodin commented Dec 21, 2022

Why do we want to let it be zero if it's zero?

I didn't understand your question, but please see a more detailed description of the change:
#8572 (comment)

I believe that's the answer to the question (if I got it right):

  1. Scan interval 0 - we use 0, since there is no point in scanning an encrypted folder if we do not scan a regular folder

@imsodin imsodin changed the title lib/model: Fix rescan interval on auto accepted encrypted folder (fixes #8572) lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes #8572) Dec 21, 2022
@imsodin imsodin merged commit f9d6847 into syncthing:main Dec 21, 2022
calmh added a commit to calmh/syncthing that referenced this pull request Dec 21, 2022
@calmh
Merge remote-tracking branch 'upstream/main' into coauthors
2532377 
* upstream/main:
  lib/fs: Watching is unsupported on android/amd64 (fixes syncthing#8709) (syncthing#8710)
  lib/model: Only log at info level if setting change time fails (syncthing#8725)
  lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes syncthing#8572) (syncthing#8573)
  gui, man, authors: Update docs, translations, and contributors
  gui: Remove unmaintained language variant nl-BE (syncthing#8722)
  gui, script: Fix indentation in lang-en.json to match others (syncthing#8721)
  docker: Ensure entrypoint is executable (syncthing#8719)
  Go 1.19.4
  Update dependencies (syncthing#8717)
  gui, man, authors: Update docs, translations, and contributors
@calmh calmh added this to the v1.22.3 milestone Dec 27, 2022
calmh added a commit to calmh/syncthing that referenced this pull request Jan 23, 2023
@calmh
Merge branch 'main' into dockerpool
f8b7cc4 
* main: (69 commits)
  Handle relay connect timeout (fixes syncthing#8749) (syncthing#8755)
  gui, man, authors: Update docs, translations, and contributors
  build: Go 1.19.5
  gui, man, authors: Update docs, translations, and contributors
  script: Add weblatedl.go for downloading updated translations (syncthing#8723)
  gui: Allow to translate action and type in Recent Changes modal (syncthing#8548)
  gui, man, authors: Update docs, translations, and contributors
  gui: Fix undefined lastSeenDays error in disconnected-inactive status check (ref syncthing#8530) (syncthing#8730)
  gui, man, authors: Update docs, translations, and contributors
  gui, api: Indicate running under container (syncthing#8728)
  lib/fs: Use io/fs errors as recommended in std lib (syncthing#8726)
  build: Handle co-authors (ref syncthing#3744) (syncthing#8708)
  lib/fs: Watching is unsupported on android/amd64 (fixes syncthing#8709) (syncthing#8710)
  lib/model: Only log at info level if setting change time fails (syncthing#8725)
  lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes syncthing#8572) (syncthing#8573)
  gui, man, authors: Update docs, translations, and contributors
  gui: Remove unmaintained language variant nl-BE (syncthing#8722)
  gui, script: Fix indentation in lang-en.json to match others (syncthing#8721)
  docker: Ensure entrypoint is executable (syncthing#8719)
  Go 1.19.4
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Dec 22, 2023
@syncthing syncthing locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@calmh calmh calmh left review comments

@imsodin imsodin imsodin approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Incorrect rescan interval on auto accepted encrypted folder
4 participants
@Ratio2 @imsodin @calmh @st-review