-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple fixes on holonomic/holonomic.py
.
#26603
Conversation
- Shallow indentation. - Changed to comprehensions. - Simplified (`if cond: return True; else: return False` to `return cond` etc).
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) | Change | Before [2487dbb5] | After [22a55b88] | Ratio | Benchmark (Parameter) |
|----------|----------------------|---------------------|---------|----------------------------------------------------------------------|
| - | 69.1±1ms | 44.4±0.4ms | 0.64 | integrate.TimeIntegrationRisch02.time_doit(10) |
| - | 68.4±0.8ms | 44.4±0.6ms | 0.65 | integrate.TimeIntegrationRisch02.time_doit_risch(10) |
| + | 18.6±0.2μs | 29.7±0.2μs | 1.6 | integrate.TimeIntegrationRisch03.time_doit(1) |
| - | 5.40±0.09ms | 2.89±0.01ms | 0.54 | logic.LogicSuite.time_load_file |
| - | 74.7±0.4ms | 28.5±0.2ms | 0.38 | polys.TimeGCD_GaussInt.time_op(1, 'dense') |
| - | 25.9±0.1ms | 16.7±0.09ms | 0.64 | polys.TimeGCD_GaussInt.time_op(1, 'expr') |
| - | 73.3±0.3ms | 28.5±0.1ms | 0.39 | polys.TimeGCD_GaussInt.time_op(1, 'sparse') |
| - | 260±3ms | 125±0.5ms | 0.48 | polys.TimeGCD_GaussInt.time_op(2, 'dense') |
| - | 253±2ms | 123±1ms | 0.49 | polys.TimeGCD_GaussInt.time_op(2, 'sparse') |
| - | 656±3ms | 370±3ms | 0.56 | polys.TimeGCD_GaussInt.time_op(3, 'dense') |
| - | 663±3ms | 372±2ms | 0.56 | polys.TimeGCD_GaussInt.time_op(3, 'sparse') |
| - | 499±10μs | 288±2μs | 0.58 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(1, 'dense') |
| - | 1.77±0.01ms | 1.05±0.01ms | 0.6 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(2, 'dense') |
| - | 5.88±0.05ms | 3.05±0.01ms | 0.52 | polys.TimeGCD_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 443±2μs | 231±2μs | 0.52 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(1, 'dense') |
| - | 1.50±0.01ms | 684±5μs | 0.45 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(2, 'dense') |
| - | 4.86±0.03ms | 1.65±0.02ms | 0.34 | polys.TimeGCD_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 373±2μs | 206±1μs | 0.55 | polys.TimeGCD_SparseGCDHighDegree.time_op(1, 'dense') |
| - | 2.43±0.01ms | 1.23±0.01ms | 0.51 | polys.TimeGCD_SparseGCDHighDegree.time_op(3, 'dense') |
| - | 10.2±0.1ms | 4.34±0.04ms | 0.42 | polys.TimeGCD_SparseGCDHighDegree.time_op(5, 'dense') |
| - | 359±1μs | 169±1μs | 0.47 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(1, 'dense') |
| - | 2.45±0.01ms | 887±10μs | 0.36 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(3, 'dense') |
| - | 9.64±0.02ms | 2.62±0.04ms | 0.27 | polys.TimeGCD_SparseNonMonicQuadratic.time_op(5, 'dense') |
| - | 1.04±0.01ms | 428±4μs | 0.41 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 1.74±0ms | 504±2μs | 0.29 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| - | 5.93±0.08ms | 1.79±0.02ms | 0.3 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'dense') |
| - | 8.61±0.2ms | 1.49±0.01ms | 0.17 | polys.TimePREM_LinearDenseQuadraticGCD.time_op(5, 'sparse') |
| - | 288±2μs | 64.5±0.4μs | 0.22 | polys.TimePREM_QuadraticNonMonicGCD.time_op(1, 'sparse') |
| - | 3.46±0.03ms | 393±2μs | 0.11 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 4.08±0.06ms | 281±2μs | 0.07 | polys.TimePREM_QuadraticNonMonicGCD.time_op(3, 'sparse') |
| - | 7.23±0.05ms | 1.26±0.01ms | 0.17 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'dense') |
| - | 8.84±0.03ms | 835±3μs | 0.09 | polys.TimePREM_QuadraticNonMonicGCD.time_op(5, 'sparse') |
| - | 5.04±0.05ms | 3.03±0.04ms | 0.6 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(2, 'sparse') |
| - | 12.2±0.2ms | 6.57±0.07ms | 0.54 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'dense') |
| - | 22.2±0.2ms | 8.98±0.02ms | 0.41 | polys.TimeSUBRESULTANTS_LinearDenseQuadraticGCD.time_op(3, 'sparse') |
| - | 5.34±0.02ms | 870±3μs | 0.16 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(1, 'sparse') |
| - | 12.8±0.2ms | 6.96±0.03ms | 0.54 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(2, 'sparse') |
| - | 102±0.7ms | 26.2±0.08ms | 0.26 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'dense') |
| - | 166±2ms | 53.9±0.2ms | 0.32 | polys.TimeSUBRESULTANTS_QuadraticNonMonicGCD.time_op(3, 'sparse') |
| - | 177±2μs | 112±0.7μs | 0.64 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'dense') |
| - | 364±2μs | 216±1μs | 0.59 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(1, 'sparse') |
| - | 4.31±0.08ms | 838±5μs | 0.19 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'dense') |
| - | 5.35±0.08ms | 390±3μs | 0.07 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(3, 'sparse') |
| - | 20.2±0.2ms | 2.83±0ms | 0.14 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'dense') |
| - | 23.1±0.2ms | 641±4μs | 0.03 | polys.TimeSUBRESULTANTS_SparseGCDHighDegree.time_op(5, 'sparse') |
| - | 483±2μs | 134±1μs | 0.28 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(1, 'sparse') |
| - | 4.75±0.02ms | 613±5μs | 0.13 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'dense') |
| - | 5.27±0.03ms | 139±0.9μs | 0.03 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(3, 'sparse') |
| - | 13.3±0.1ms | 1.31±0ms | 0.1 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'dense') |
| - | 14.2±0.08ms | 142±0.6μs | 0.01 | polys.TimeSUBRESULTANTS_SparseNonMonicQuadratic.time_op(5, 'sparse') |
| - | 136±0.9μs | 76.3±0.4μs | 0.56 | solve.TimeMatrixOperations.time_rref(3, 0) |
| - | 252±2μs | 90.1±0.5μs | 0.36 | solve.TimeMatrixOperations.time_rref(4, 0) |
| - | 24.2±0.4ms | 10.2±0.06ms | 0.42 | solve.TimeSolveLinSys189x49.time_solve_lin_sys |
| - | 29.6±0.3ms | 15.6±0.06ms | 0.53 | solve.TimeSparseSystem.time_linsolve_Aaug(20) |
| - | 57.1±0.5ms | 25.0±0.08ms | 0.44 | solve.TimeSparseSystem.time_linsolve_Aaug(30) |
| - | 29.6±0.2ms | 15.2±0.1ms | 0.51 | solve.TimeSparseSystem.time_linsolve_Ab(20) |
| - | 57.0±0.4ms | 24.8±0.1ms | 0.43 | solve.TimeSparseSystem.time_linsolve_Ab(30) |
Full benchmark results can be found as artifacts in GitHub Actions |
Co-authored-by: S.Y. Lee <sylee957@gmail.com>
if cond: return True; else: return False
toreturn cond
etc).References to other Issues or PRs
Brief description of what is fixed or changed
Other comments
Release Notes
NO ENTRY