-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint(ci): avoid cython 0.29.31 under PyPy #23847
Conversation
✅ Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.
Click here to see the pull request description that was parsed.
|
This doesn't work because I think when SciPy builds it installs its own version of Cython and so still picks up 0.29.31 even if we don't install that version. |
I've opened a SciPy issue: scipy/scipy#16723 For now I'll make the PyPy job an allowed failure in CI (the 3.11 job already is). |
67c02ee
to
742eb6e
Compare
89fd1ae
to
e3bdde9
Compare
Benchmark results from GitHub Actions Lower numbers are good, higher numbers are bad. A ratio less than 1 Significantly changed benchmark results (PR vs master) Significantly changed benchmark results (master vs previous release) Full benchmark results can be found as artifacts in GitHub Actions |
Reverts sympyGH-23847 since Cython 0.29.32 was released making it unnecessary.
References to other Issues or PRs
#23061 (comment)
Brief description of what is fixed or changed
The PyPy optional dependency job avoids Cython 0.29.31 which fails to build SciPy 1.8.1. This is probably an upstream bug in either Cython or SciPy.
Other comments
For a brief moment the CPython 3.11.0b5 release hit CI and we actually had everything pass on master (25cbe76). Within hours though two different problems emerged and the next merge to master (dc86589) has two jobs failing both in the build of SciPy.
It's not clear yet what the problems are that cause this or if they are related. They seem to be because they both show the same error pointing at
However the two jobs use different versions of everything. The PyPy job installs cython, numpy and scipy all from pip to retrieve the latest versions. The only thing that seems to have changed there is the release of Cython 0.29.31.
The 3.11 job now uses CPython 3.11.0b5 and installs cython, numpy and scipy from git master/main. The Cython master branch currently reports as Cython-3.0.0a10. It's not clear if there has been a change in Cython master or a change in SciPy main that has caused this to fail but since the error message is similar to the one seen with Cython 0.29.31 maybe they are releated.
Release Notes
NO ENTRY