Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(doc): unpin sphinx version for the docs build #23664

Merged
merged 1 commit into from Jun 21, 2022

Conversation

oscarbenjamin
Copy link
Contributor

The docs build was temporarily pinned due to

sphinx-doc/sphinx#10538

References to other Issues or PRs

See #20623 (comment)

Brief description of what is fixed or changed

Unpin the sphinx version used to build the docs so that the latest release will always be used.

Other comments

Release Notes

NO ENTRY

@sympy-bot
Copy link

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

  • No release notes entry will be added for this pull request.
Click here to see the pull request description that was parsed.
The docs build was temporarily pinned due to

  https://github.com/sphinx-doc/sphinx/issues/10538

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->

See https://github.com/sympy/sympy/issues/20623#issuecomment-1161692412

#### Brief description of what is fixed or changed

Unpin the sphinx version used to build the docs so that the latest release will always be used.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

@github-actions
Copy link

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

       before           after         ratio
     [596257ec]       [126b6194]
+       619±0.9μs       1.26±0.6ms     2.04  polygon.PolygonAttributes.time_perimeter
+        562±40μs       1.21±0.6ms     2.15  polygon.PolygonAttributes.time_sides

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [77f1d79c]       [596257ec]
     <sympy-1.10.1^0>                 
+      99.0±0.6ms        179±0.9ms     1.81  sum.TimeSum.time_doit

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin oscarbenjamin merged commit a28a214 into sympy:master Jun 21, 2022
@oscarbenjamin oscarbenjamin deleted the pr_unpin_sphinx branch June 21, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants