Rubi progress and tests #14756

ashishkg0022 · 2018-05-30T10:58:16Z

integrals
- Made rubi stable.
- Added missing utility functions
- Added large test set

I pulled out the common functionality to be evaluated once, and used array() instead of asarray() (they are equivalent, but array() is faster). This is a partial fix to sympy#14671. It isn't as fast as it used to be yet. I don't know how to make the decorator faster, other than code generating the array wrapping directly, which would require improvements to lambdify to work (lambdify would need to be able to code generation full Python functions).

ashishkg0022 · 2018-05-30T11:04:53Z

In original test suite for trinomial products there are 5 files. In sympy format I have kept it here. https://github.com/ashishkg0022/rubi-structure/tree/master/test/trinomial . This contains all trinomial tests from the rubi test-suite.
I have added test_trinomial_passed in this PR . This contains tests which are passed for trinomial_1 . Almost 600 test have passed for trinomial_1 . I started testing trinomial_2 . Then I encountered with issues like

With Function is not handled properly. It should be parsed correctly.
Some times Matchpy wrongly matches x with some integer
and some small issues.
The most important for now is fixing the With issue. Then majority of trinomial_2 should pass.

ashishkg0022 · 2018-05-30T11:05:27Z

ping @Upabjojr @parsoyaarihant

ashishkg0022 · 2018-05-30T11:48:38Z

Also

In [1]: from sympy.abc import a,b,c,x, e, d

In [2]: b*e - c*d
Out[2]: b*e - c*d

but in mathematica

In[1]:= b*e - c*d
Out[1]= -cd+be

This results in difference because there is a function PosQ which treats b*e -c*d True and -c*d +b*e False

arihantparsoya · 2018-05-31T08:03:16Z

Some times Matchpy wrongly matches x with some integer

This should be reported to MatchPy developers. Can you share a sample case where this fails?

arihantparsoya · 2018-05-31T08:14:27Z

Regadring difference in output of SymPy and Mathematica, Mathematica sorts the expression canonically. See: http://reference.wolfram.com/language/ref/Orderless.html http://reference.wolfram.com/language/ref/Sort.html

You can use Sort in the utility function to address this issue.

ashishkg0022 · 2018-05-31T09:21:50Z

You can use Sort in the utility function to address this issue.

It handles rest of the cases . But specifically the case b*e -c*d is not sorted by the Sort function too.

arihantparsoya · 2018-05-31T09:24:54Z

You can create this as a SymPy issue. We might have to improve the Sort function we already have to take care of this.

Abdullahjavednesar · 2018-07-23T13:58:58Z

@ashishkg0022 for those utility functions which you've recently modified have you added relevant tests for all (which probably was failing before)? Although I've seen your work before looks good to me, but if you are missing anywhere just recheck.

ashishkg0022 · 2018-07-23T16:00:32Z

Yes, I think I have added test cases for them.

ashishkg0022 · 2018-07-23T16:31:51Z

There are some more things that need to be done to improve utility functions.
I have opened a separate PR especially for improving utility functions. ( #14956)

ashishkg0022 · 2018-07-24T11:51:36Z

I apologise, I have not run pyflakes on it. I was not aware of it (pyflakes). I will run it today and fixed if something is undefined. I will fix it today. Then this can be merged.

sympy-bot · 2018-07-24T12:46:03Z

✅

Hi, I am the SymPy bot (v119). I'm here to make sure this pull request has a release notes entry. Please read the guide on how to write release notes.

Click here to see the pull request description that was parsed.

<!-- BEGIN RELEASE NOTES -->
* integrals
    * Made rubi stable.
    * Added missing utility functions
    * Added large test set

<!-- END RELEASE NOTES -->

Your release notes are in good order.

Here is what the release notes will look like:

integrals
- Made rubi stable. (#14756 by @ashishkg0022 and @asmeurer)
- Added missing utility functions (#14756 by @ashishkg0022 and @asmeurer)
- Added large test set (#14756 by @ashishkg0022 and @asmeurer)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.2.1.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Update

The release notes on the wiki have been updated.

ashishkg0022 · 2018-07-24T16:00:47Z

Fixed few undefined error using pyflakes.

certik · 2018-07-25T14:31:14Z

@Upabjojr would you mind reviewing this PR please and give it a final +1?

Upabjojr · 2018-07-25T16:14:53Z

@ashishkg0022 did you add the instructions on how to run the tests?

Upabjojr · 2018-07-25T16:16:12Z

sympy/integrals/rubi/__init__.py

+Parsing Rules and Tests
+=======================
+Code for parsing rule and tests are included in sympy.
+They have been properly explained with steps in `rubi_parsing_guide.md` in parsetools.


full path of rubi_parsing_guide.md is better

Upabjojr · 2018-07-25T16:20:09Z

sympy/utilities/runtests.py

@@ -671,6 +671,7 @@ def _doctest(*paths, **kwargs):
        "sympy/physics/unitsystems.py", # raises deprecation warning
        "sympy/parsing/latex/_antlr/latexlexer.py", # generated code
        "sympy/parsing/latex/_antlr/latexparser.py", # generated code
+        "sympy/integrals/rubi/rubi.py"


are we blacklisting the doctests as well?

only for rubi.py, not for utility_functions.
Actually, the loading time is around 10 - 11 minutes. So, travis fails. If nothing happens in 10 minutes, travis fails. So I have blacklisted it.

Upabjojr · 2018-07-26T09:42:57Z

I guess the master branch should be merged into this PR.

ashishkg0022 · 2018-07-26T10:05:16Z

I guess the master branch should be merged into this PR.

I have merged the master branch

ashishkg0022 · 2018-07-26T10:05:51Z

The travis failed due to some network error.

Upabjojr · 2018-07-26T16:24:23Z

Some of the rubi tests keep failing. For example, test_1_3.py, is it supposed to be like that?

ashishkg0022 · 2018-07-26T16:36:45Z

test_1_3.py is from last year. I have not run it due to a large time taken by it.
What is the status of newly added test files? Do a lot of them fail?

Upabjojr · 2018-07-26T16:42:12Z

Do a lot of them fail?

I didn't test them all so far.

ashishkg0022 · 2018-07-26T16:50:33Z

Can you please run them all? I have tested them in part. I have not run them all together. Like, when I tested exponentials they passed. But after a week I made some changes in trigo rules and utility functions. So it might be possible very few might fail because of some changes done later. For any new change, it's not possible to run all tests again.

asmeurer · 2018-07-26T19:20:37Z

Regarding the release notes, I accidentally added rubi as a submodule, but since it's been moved to integrals.rubi, the header should just be "integrals" (I've fixed it). c.f. sympy/sympy-bot#16. If there end up being a lot of integrals release notes we can split them up into different subsubmodules like integrals.risch, integrals.rubi, and so on.

Upabjojr · 2018-07-27T13:33:00Z

For the rubi_test results:
https://gist.github.com/Upabjojr/02cf3005ec995c7401418624a4bc11c7

ashishkg0022 · 2018-07-27T13:49:30Z

I saw it. Tests which I have run recently like hyperbolic are passing but a few of trinomials and miscellaneous algebra might be failing. Is there some way I can get a list of all expressions in the test set which are failing?

Upabjojr · 2018-07-27T14:16:05Z

You have the line numbers. Some tests are actually still running.

Upabjojr · 2018-07-28T16:26:38Z

Shall we merge this PR?

I have still two tests of rubi_tests running, so far it's 30 hours. I will update the output once they are all finished.

Upabjojr · 2018-07-28T16:27:32Z

@parsoyaarihant @Abdullahjavednesar ok with merging?

asmeurer and others added 12 commits May 18, 2018 00:45

fixed_order

1b60063

Merge branch 'separate_cons' into rubi_progress

64c823b

fixed minors

23db713

fixed minor issues to pass test_1_2

a8d4b51

updated utility functions

4391449

improved defn of AppellF1

89910a8

corrected positiveQ

127602c

Updated for keeping track of rules applied

5055ba5

corrected trinomialMatchQ

5b598ef

corrected binomialMatchQ

ff9560d

updated all

1913931

ashishkg0022 changed the title ~~Rubi progress and tests~~ [Not for merging]Rubi progress and tests May 30, 2018

Upabjojr added the integrals.rubi label May 30, 2018

ashishkg0022 added 2 commits May 31, 2018 00:55

indentation corrected

6809a1e

minor correct

2d25d8a

ashishkg0022 added 7 commits May 31, 2018 18:40

corrected PolyQ

bd4c633

corrected With definitions

987bd2f

minor

57e1bca

Solved exceptions and wrong output

a26e091

updated utility functions

574bb6b

added test for trinomial

c7a6241

updated cons

7184bc2

updated init

32002d5

ashishkg0022 mentioned this pull request Jul 22, 2018

[WIP] utility_functions of rubi 4.15 #14956

Open

fixed undefinef issues after running pyflakes

224f1ed

Upabjojr reviewed Jul 25, 2018

View reviewed changes

Abdullahjavednesar added the PR: author's turn The PR has been reviewed and the author needs to submit more changes. label Jul 25, 2018

ashishkg0022 added 2 commits July 25, 2018 23:38

added instructions for running tests

db2b423

solved merge conflicts

c6ed3dd

Upabjojr merged commit bccd4f3 into sympy:master Jul 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rubi progress and tests #14756

Rubi progress and tests #14756

ashishkg0022 commented May 30, 2018 •

edited by asmeurer

ashishkg0022 commented May 30, 2018

ashishkg0022 commented May 30, 2018

ashishkg0022 commented May 30, 2018

arihantparsoya commented May 31, 2018 •

edited

arihantparsoya commented May 31, 2018 •

edited

ashishkg0022 commented May 31, 2018

arihantparsoya commented May 31, 2018

Abdullahjavednesar commented Jul 23, 2018

ashishkg0022 commented Jul 23, 2018

ashishkg0022 commented Jul 23, 2018

ashishkg0022 commented Jul 24, 2018

sympy-bot commented Jul 24, 2018 •

edited

ashishkg0022 commented Jul 24, 2018

certik commented Jul 25, 2018

Upabjojr commented Jul 25, 2018

Upabjojr Jul 25, 2018

Upabjojr Jul 25, 2018

ashishkg0022 Jul 25, 2018

Upabjojr commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

Upabjojr commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

Upabjojr commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

asmeurer commented Jul 26, 2018

Upabjojr commented Jul 27, 2018

ashishkg0022 commented Jul 27, 2018

Upabjojr commented Jul 27, 2018

Upabjojr commented Jul 28, 2018

Upabjojr commented Jul 28, 2018

Rubi progress and tests #14756

Rubi progress and tests #14756

Conversation

ashishkg0022 commented May 30, 2018 • edited by asmeurer

ashishkg0022 commented May 30, 2018

ashishkg0022 commented May 30, 2018

ashishkg0022 commented May 30, 2018

arihantparsoya commented May 31, 2018 • edited

arihantparsoya commented May 31, 2018 • edited

ashishkg0022 commented May 31, 2018

arihantparsoya commented May 31, 2018

Abdullahjavednesar commented Jul 23, 2018

ashishkg0022 commented Jul 23, 2018

ashishkg0022 commented Jul 23, 2018

ashishkg0022 commented Jul 24, 2018

sympy-bot commented Jul 24, 2018 • edited

ashishkg0022 commented Jul 24, 2018

certik commented Jul 25, 2018

Upabjojr commented Jul 25, 2018

Upabjojr Jul 25, 2018

Choose a reason for hiding this comment

Upabjojr Jul 25, 2018

Choose a reason for hiding this comment

ashishkg0022 Jul 25, 2018

Choose a reason for hiding this comment

Upabjojr commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

Upabjojr commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

Upabjojr commented Jul 26, 2018

ashishkg0022 commented Jul 26, 2018

asmeurer commented Jul 26, 2018

Upabjojr commented Jul 27, 2018

ashishkg0022 commented Jul 27, 2018

Upabjojr commented Jul 27, 2018

Upabjojr commented Jul 28, 2018

Upabjojr commented Jul 28, 2018

ashishkg0022 commented May 30, 2018 •

edited by asmeurer

arihantparsoya commented May 31, 2018 •

edited

arihantparsoya commented May 31, 2018 •

edited

sympy-bot commented Jul 24, 2018 •

edited